Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cache-Control header #14

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Conversation

toshinari123
Copy link
Contributor

fixed issue #11

@kiootic
Copy link
Collaborator

kiootic commented Jan 2, 2024

@toshinari123

  • The indentation for Go uses tab instead of spaces, please run the Go formatter when you edit the code.
  • The compiled binary is accidentally committed into the repo.

@limouren
Copy link

limouren commented Jan 3, 2024

Just passing by, cache control should be configurable?

@kiootic
Copy link
Collaborator

kiootic commented Jan 3, 2024

This is just a reasonable default for Cache-Control header. Customization of headers would be handled separately.

@limouren
Copy link

limouren commented Jan 4, 2024

icic. It makes sense.

internal/handler/site/site_handler.go Outdated Show resolved Hide resolved
internal/handler/site/site_handler.go Outdated Show resolved Hide resolved
@kiootic kiootic merged commit 2a0ce74 into oursky:main Jan 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants