Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty proposer & remove desmos #280

Merged

Conversation

ivanng-oursky
Copy link
Contributor

@ivanng-oursky ivanng-oursky commented Jul 15, 2022

This would be shown if empty proposer, the error is fixed by removing profile

image

refs #269, #274

@ivanng-oursky ivanng-oursky marked this pull request as ready for review July 15, 2022 04:41
@hochiw
Copy link
Contributor

hochiw commented Jul 15, 2022

@ivanng-oursky do we use avatar_url from bdjuno validator_description table for profile picture instead?

@ivanng-oursky
Copy link
Contributor Author

@ivanng-oursky do we use avatar_url from bdjuno validator_description table for profile picture instead?

as discussed offline, we'll use the avatar url from keybase fetched using the identity field from validator description from rpc, I have opened a new issue to track this #282

@hochiw
Copy link
Contributor

hochiw commented Jul 15, 2022

@ivanng-oursky conflicted

@ivanng-oursky ivanng-oursky force-pushed the 269-274-fix-empty-proposer-remove-desmos branch from 70f5b17 to 8a33e11 Compare July 18, 2022 03:23
@ivanng-oursky
Copy link
Contributor Author

@hochiw resolved 🙇

@hochiw
Copy link
Contributor

hochiw commented Jul 18, 2022

@ivanng-oursky conflicted 2.0

@ivanng-oursky ivanng-oursky force-pushed the 269-274-fix-empty-proposer-remove-desmos branch from 8a33e11 to 11907f6 Compare July 18, 2022 08:06
@ivanng-oursky
Copy link
Contributor Author

@hochiw conflict 2.0 resolved 🙇

@hochiw hochiw merged commit e3ed697 into oursky:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants