-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/Fix: WassersteinSolver constructor now throws TypeError when an unrecognized argument is given #579
Closed
selmanozleyen
wants to merge
6
commits into
ott-jax:main
from
selmanozleyen:refactor/was-solver-unrecognized-kwargs
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
201a806
add checks for was solver
selmanozleyen 73e6f54
add tests for GWSolvers
selmanozleyen bd6672c
maybe try to fix precommits?
selmanozleyen 62b7582
Revert "maybe try to fix precommits?"
selmanozleyen a3b30c8
Revert "add tests for GWSolvers"
selmanozleyen 88bde47
formatting fix
selmanozleyen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I think there's a slightly better solution rather than inspecting the signature of the linear solvers,
I'd rather make
linear_ot_solver
a required argument and remove the construction of the solver in__init__
altogether - this will require some changes, esp. in tests, inott/solvers/quadratic/_solve.py
, etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then this means we can also remove
kwargs
right? I'd also prefer this toinspect
but didn't want to change the interface in case you had other plans.