fix: kill ghost clients when they're afk

events/bancho.py

@@ -211,10 +211,11 @@ async def login(req: Request) -> Response:
         services.bcrypt_cache[user_password] = password_md5
 
     if target := services.players.get(user_info["username"]):
-        # user is already online? sus
+        timeago_format = datetime.fromtimestamp(target.last_update)
         return failed_login(
             LoginResponse.INCORRECT_LOGIN,
-            msg=f"A user tried to sign in to {target!r} which is already online. ",
+            msg=f"A user tried to sign in to {target!r} which is already online. "
+            f"(last session update was {timeago.format(timeago_format)}))",
             extra=writer.notification(ALREADY_ONLINE),
         )
 

tasks.py

@@ -32,16 +32,12 @@ def decorator(cb: Callable) -> None:
     return decorator
 
 
-@register_task(delay=1)
+@register_task(delay=5)
 async def removed_expired_tokens() -> None:
     for player in services.players:
         # doesn't look like afk players get the afk thingy thing thing
         # ^^^ bro what?
-        if (
-            time.time() - player.last_update >= TOKEN_EXPIRATION
-            and not player.bot
-            and player.status != ActionStatus.AFK
-        ):
+        if time.time() - player.last_update >= TOKEN_EXPIRATION and not player.bot:
             await player.logout()
             services.logger.info(
                 f"{player.username} has been logged out, due to loss of connection."