-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2023.8-3 coverity minor fixes #3263
Commits on Jun 12, 2024
-
checksum: Null terminate buffer
Coverity points out that `buffer` is an unterminated string. g_checksum_update() expects a null-terminated string.
Configuration menu - View commit details
-
Copy full SHA for a8c3c3d - Browse repository at this point
Copy the full SHA a8c3c3dView commit details -
Coverity points out that we have a memory leak from `g_strdup(name)`
Configuration menu - View commit details
-
Copy full SHA for 20a333c - Browse repository at this point
Copy the full SHA 20a333cView commit details -
commit: Null terminate
target_buf
varCoverity points out that we are passing an unterminated string to sprintf().
Configuration menu - View commit details
-
Copy full SHA for f120b7b - Browse repository at this point
Copy the full SHA f120b7bView commit details -
repo: Return copy of local var
ret
Coverity points out that we are returning `stbuf` which is a local variable.
Configuration menu - View commit details
-
Copy full SHA for d049c1f - Browse repository at this point
Copy the full SHA d049c1fView commit details -
repo: Free actual pointer instead of stolen pointer
Coverity points out that ostree_repo_finder_result_free() is freeing an incorrect pointer `(gpointer)g_steal_pointer(&results->pdata[i])`. Since we are not returning this value, we shouldn't need to transfer ownership of the pointer. Instead, we should free the actual pointer.
Configuration menu - View commit details
-
Copy full SHA for 22b77f1 - Browse repository at this point
Copy the full SHA 22b77f1View commit details -
Coverity points out that we have a memory leak from `ret_rollsum`.
Configuration menu - View commit details
-
Copy full SHA for 383f908 - Browse repository at this point
Copy the full SHA 383f908View commit details -
repo: Autofree
dir_or_file_path
Coverity points out that we have a memory leak from g_strdup(dir_or_file_path).
Configuration menu - View commit details
-
Copy full SHA for b42ef62 - Browse repository at this point
Copy the full SHA b42ef62View commit details -
repo: Autofree contents of
input_mfile
Coverity points out that we have memory leak from g_mapped_file_get_contents(input_mfile).
Configuration menu - View commit details
-
Copy full SHA for 81125ff - Browse repository at this point
Copy the full SHA 81125ffView commit details -
Coverity points out that we have a memory leak from g_strdup(devpath).
Configuration menu - View commit details
-
Copy full SHA for 377dc62 - Browse repository at this point
Copy the full SHA 377dc62View commit details -
prepare: Change mount
etc
to absolute pathCoverity points out that ""/sysroot.tmp/etc"" could be a copy-paste error.
Configuration menu - View commit details
-
Copy full SHA for 4b0fec2 - Browse repository at this point
Copy the full SHA 4b0fec2View commit details