Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkout: Add API to directly checkout composefs #3252

Merged
merged 1 commit into from
May 23, 2024

Conversation

cgwalters
Copy link
Member

We were missing the simple, obvious API and CLI to go from ostree commit -> composefs.

Internally, we had ostree_repo_checkout_composefs with the right "shape" mostly, except it had more code in the deploy path to turn that into a composefs.

Add a straightforward public API that does what
the deploy code did before, and then the old
API becomes an explicitly internal helper with an _ prefix.

Goals:

  • Lead towards a composefs-oriented future
  • This makes the composefs logic more testable directly

@cgwalters
Copy link
Member Author

It's hard to overstate the extent to which we just really really need to do a hard switch to composefs, it will make so many things better.

@cgwalters cgwalters force-pushed the checkout-cfs branch 3 times, most recently from 889111b to b7d391f Compare May 23, 2024 00:19
We were missing the simple, obvious API and CLI to go
from ostree commit -> composefs.

Internally, we had `ostree_repo_checkout_composefs`
with the right "shape" mostly, except it had more code
in the deploy path to turn that into a composefs.

Add a straightforward public API that does what
the deploy code did before, and then the old
API becomes an explicitly internal helper with an `_`
prefix.

Goals:

- Lead towards a composefs-oriented future
- This makes the composefs logic more testable directly

Signed-off-by: Colin Walters <[email protected]>
@cgwalters cgwalters merged commit a2ae287 into ostreedev:main May 23, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants