configure: fix composefs default to on, if appropriate #3071
Conversation
composefs should be included by default. If the appropriate headers are not present, have_mount_attr_idmap should be set to no. If this is no, don't build composefs as part of the build.
|
@ericcurtin: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I don't understand how this changes anything? Like we were checking |
|
I suspect have_mount_attr_idmap was never getting set correctly, so composefs_default was always being set as no. Because != yes covers the unset case also. I'm not confident that this is the best fix, this was tested in Fedora, after this change composefs is on because checking for == xno is a more explicit stricter check than != xyes. But a full test would be to test on an older kernel also, to see if it's no in that case, an explanation of why this conditional stuff was introduced is here: |
|
The build being red I guess proves composefs is always on with this change. Maybe I can take a look at this when I'm back, although I'm not an autotools expert. |
There was a problem hiding this comment.
I just tested this quickly, running a default build without --with-composefs does enable composefs.
The real problem is in #3067
But I'm fine to land this too, just needs a rebase.
But, this change is perhaps clearer so I'm also fine to land it.
|
You are right @cgwalters ... Closing... |
composefs should be included by default. If the appropriate headers are
not present, have_mount_attr_idmap should be set to no. If this is no,
don't build composefs as part of the build.