Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an always-on inode64 feature #2946

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Add an always-on inode64 feature #2946

merged 1 commit into from
Jul 20, 2023

Conversation

cgwalters
Copy link
Member

As I (and others) will be backporting the fix in
de6fddc pretty far, I want a way for sysadmins and OS builders to be able to reliably see when their version of ostree has this fix (Because comparing version numbers isn't portable).

@ericcurtin
Copy link
Collaborator

ericcurtin commented Jul 20, 2023 •
edited
Loading

Looks like these are not flakes, tests say no:

image

@ericcurtin ericcurtin disabled auto-merge July 20, 2023 13:21
@cgwalters
Copy link
Member Author

Yeah, need to use $OSTREE in some of the CI tests to get the uninstalled binary...for some reason we're not overrding PATH properly? Kind of a bug. The whole "test things uninstalled" is really a mess. But anyways this should be right now.

@cgwalters
Copy link
Member Author

OK well, some tests mutate $OSTREE, argh...I'm just making a new test.

@cgwalters
Copy link
Member Author

Oh my god fighting with automake under time pressure is just like The Worst Thing.

@cgwalters
Copy link
Member Author

Well, I have just no idea right now why tap_ok and tap_end are working in other tests even with older automake, but this one isn't. There's some sort of sorcery I'm missing. Anyways, it's fine, we'll just use the old tap API.

@cgwalters
Add an always-on inode64 feature
8ce7bbe 
As I (and others) will be backporting the fix in
ostreedev@de6fddc
pretty far, I want a way for sysadmins and OS builders to
be able to reliably see when their version of ostree has this fix
(Because comparing version numbers isn't portable).
@cgwalters
Copy link
Member Author

Well now I'm worried that this is somehow turning up "some CI tests aren't testing the code in the PR" which would be very exciting... I think it may relate to something in the "distcheck" flow and us not having $PATH set correctly.

Anyways, let's just get the feature in...

@cgwalters cgwalters merged commit a035c2e into ostreedev:main Jul 20, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericcurtin ericcurtin ericcurtin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgwalters @ericcurtin