Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bazel: various fixes #9243
Bazel: various fixes #9243
Changes from all commits
e4bced9
0ac906a
3ad055a
e4046fe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 36 in clients/bazel-module-registry/src/main/kotlin/LocalBazelModuleRegistryService.kt
GitHub Actions / qodana-scan
Unresolved reference in KDoc
Check warning on line 36 in clients/bazel-module-registry/src/main/kotlin/LocalBazelModuleRegistryService.kt
GitHub Actions / qodana-scan
Unresolved reference in KDoc
Check warning on line 38 in clients/bazel-module-registry/src/main/kotlin/RemoteBazelModuleRegistryService.kt
GitHub Actions / qodana-scan
Unresolved reference in KDoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this. Do you mean "can be relevant e.g. in case a specific '.bazelrc'
depending on the value of an environment variable is defined"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to explain the setup of our customer project and the phrasing is quite difficult...
They have in their project a wrapper script in
tools/bazel
. This script reads an environment variable and, depending on its value, change the .bazelrc of the project.Therefore when you call
bazel mod graph
, this script "setups" your build environment depending on this environment variable.However, bazel uses this script for all commands even if you call
bazel version
. In that case, the script fails because it does not support the--version
parameter. While the correct fix would be to change the wrapper script to support this parameter, this is not possible to force all the projects to do so.And, in all cases, ORT must make sure that the wrapper script is enabled when
mod graph
is called, as it may contain some build changing logic as described above.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this should be
debug
instead ofinfo
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the logging occurs only one, I think there is no harm in letting it to
info
, especially considering how noisydebug
is.