Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Simplify the reuse check #9229

Merged
merged 1 commit into from
Oct 1, 2024
Merged

ci: Simplify the reuse check #9229

merged 1 commit into from
Oct 1, 2024

Conversation

mnonnenmacher
Copy link
Member

After upgrading to Ubuntu 24.04 in 90c8fb0 we do not need to setup a specific Python version anymore, but with the pre-installed Python we need to use pipx instead of pip to install the package.

After upgrading to Ubuntu 24.04 in 90c8fb0 we do not need to setup a
specific Python version anymore, but with the pre-installed Python we
need to use `pipx` instead of `pip` to install the package.

Signed-off-by: Martin Nonnenmacher <[email protected]>
@mnonnenmacher mnonnenmacher requested a review from a team as a code owner October 1, 2024 15:08
@sschuberth
Copy link
Member

with the pre-installed Python we need to use pipx instead of pip to install the package.

Nit: It would be nice to explain why this is needed.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.65%. Comparing base (3b0c858) to head (f835e54).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9229   +/-   ##
=========================================
  Coverage     67.65%   67.65%           
  Complexity     1185     1185           
=========================================
  Files           239      239           
  Lines          7795     7795           
  Branches        899      899           
=========================================
  Hits           5274     5274           
  Misses         2153     2153           
  Partials        368      368           
Flag Coverage Δ
funTest-docker 60.23% <ø> (ø)
funTest-non-docker 34.71% <ø> (ø)
test 37.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mnonnenmacher mnonnenmacher merged commit f92ad12 into main Oct 1, 2024
23 checks passed
@mnonnenmacher mnonnenmacher deleted the simplify-reuse branch October 1, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants