Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test curations with empty name / version #5971

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

sschuberth
Copy link
Member

Please have a look at the individual commit messages for the details.

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 57.89% // Head: 57.89% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (e63f12b) compared to base (43b5578).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5971   +/-   ##
=========================================
  Coverage     57.89%   57.89%           
  Complexity     2040     2040           
=========================================
  Files           322      322           
  Lines         18700    18696    -4     
  Branches       3833     3832    -1     
=========================================
- Hits          10826    10824    -2     
+ Misses         6821     6819    -2     
  Partials       1053     1053           
Flag Coverage Δ
funTest-analyzer-docker 74.69% <ø> (ø)
funTest-non-analyzer 50.46% <ø> (+0.01%) ⬆️
test 27.55% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/main/kotlin/provenance/ProvenanceDownloader.kt 38.88% <0.00%> (-3.22%) ⬇️
model/src/main/kotlin/config/OrtConfiguration.kt 97.29% <0.00%> (-0.21%) ⬇️
.../curation/ClearlyDefinedPackageCurationProvider.kt 48.80% <0.00%> (+2.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sschuberth sschuberth force-pushed the test-curations-with-empty-name branch from c20865b to a949115 Compare October 20, 2022 06:03
@sschuberth sschuberth requested review from mnonnenmacher and a team October 20, 2022 06:03
mnonnenmacher
mnonnenmacher previously approved these changes Oct 20, 2022
fviernau
fviernau previously approved these changes Oct 20, 2022
This is in context of [1].

[1]: #5105 (comment)

Signed-off-by: Sebastian Schuberth <[email protected]>
@sschuberth sschuberth merged commit 82993c1 into main Oct 20, 2022
@sschuberth sschuberth deleted the test-curations-with-empty-name branch October 20, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants