Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added example notebooks #297

Closed
wants to merge 7 commits into from
Closed

Added example notebooks #297

wants to merge 7 commits into from

Conversation

IvanSpirandelli
Copy link
Collaborator

No description provided.

@kalmarek
Copy link
Contributor

I had a look at those notebooks and they seem to be ok.
I would prefer a separate folder with Project/Manifest.toml fixing the environment.

@saschatimme
Copy link
Collaborator

Not related to this particular PR, but we should also update or delete the other example notebook.
(Or use something like Literate.jl to also integrate them into CI).

@kalmarek
Copy link
Contributor

the other notebook is kept by @micjoswig here:
https://github.com/micjoswig/oscar-notebooks/blob/master/polymake/g-vectors_of_random_simplicial_6-polytopes.ipynb
@micjoswig maybe those notebooks created by @IvanSpirandelli should go there as well?

I like @saschatimme suggestion about using Literate.jl though

@benlorenz
Copy link
Member

I would prefer to have them here in the Polymake.jl repository (or a new repo under oscar-system), and they should be tested automatically, see #268.

@IvanSpirandelli
Copy link
Collaborator Author

I added the tomls and created folders for the examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants