Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add letters function for PcGroupElem #4202

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jamesnohilly
Copy link

Moved the syllable functions from the mjrodgers-OW_GModules branch to this to use as a reference for new work.

  • New function letters for (Sub)PcGroupElem.
  • A check in exponent_vector for whether the input is really "canonical".
  • Test cases in test/Groups/pcgroups.jl for the new functions.
  • Add doc strings for new functions.

Suggestions from @fingolfin

Moved from the mjrodgers-OW_GModules branch.
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 84.58%. Comparing base (da7acb0) to head (e9a4ac4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Groups/pcgroup.jl 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4202      +/-   ##
==========================================
- Coverage   84.59%   84.58%   -0.02%     
==========================================
  Files         631      631              
  Lines       84899    84915      +16     
==========================================
  Hits        71824    71824              
- Misses      13075    13091      +16     
Files with missing lines Coverage Δ
src/Groups/pcgroup.jl 62.58% <0.00%> (-8.15%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants