fix indentation and line lenghts in Task.hpp's template #134
Conversation
| * It can be dynamically adapted when the deployment is called with a prefix argument. | ||
| short_doc, *long_doc = doc.split("\n") | ||
| %>/*! \class <%= task.basename %> | ||
| * \brief <%= short_doc %><%= "\n *" + long_doc.join("\n * ") unless long_doc.empty? %> | ||
| */ | ||
| class <%= task.basename %> : public <%= task.basename %>Base | ||
| { |
There was a problem hiding this comment.
Could you please also move the braces to the previous line?
| @@ -106,4 +105,3 @@ namespace <%= space %>{ | |||
| <% end %> | |||
|
|
|||
| #endif | |||
|
|
|||
There was a problem hiding this comment.
rock_vera requires the final newline
|
Hi @g-arjones. Thanks for putting the finger where it hurts. The whole vera thing has not delivered for me. It's very hard to extend and is unsupported by essentially anyone. For instance, it will complain about missing spaces after I've started toying with using Why am I talking about it now ? I just realized I haven't fixed the If you agree, let's put this as draft, and move the discussion to the team discussion ? |
|
Yeah, well, I have spent A LOT of time looking into all the options multiple times now and I really believe vera++ is the best one (cpplint is a close second option but it's not extendable at all) if we want "live" linting (and I agree it sucks, btw). I don't think turning clang-format into a linter is feasible if you want meaningful error/warning messages. The reality for me is that linting C/C++ is very hard and no one cares enough to try to fix the situation. Now, what I believe would provide the best value (with a tradeoff in usability) is using clang-tidy and getting rid of vera++. It's highly customizable and has plenty of checks but requires the tool to be able to "build" the code. Since it supports compilation databases, the vscode extension could wait until it finds one to actually try to lint the code (that's the drawback in usability I mentioned before). It's supported by cmake with a flag so we could consider integrating with the CI through rock macros as well.
Fine 👍 |
Headers usually don't show up in those so there is that.. :( |
No description provided.