Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune legacy code #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prune legacy code #99

wants to merge 1 commit into from

Conversation

ThirteenFish
Copy link
Contributor

@ThirteenFish ThirteenFish commented Jul 10, 2024

-150k loc. Moving from OreSat0 to OreSat0.5 saw significant hardware
changes that until this point hadn't been reflected in this repo. This
commit removes support for the no longer used hardware, including old
boards, drivers for no longer used devices, and STM32F4/L4
microcontrollers entirely. Of note:

  • The archive is gone. Its contents, like the rest of the removals here
    can be accessed in git history.
  • The C3 is now Linux based. Removing the old project means we can drop
    our custom ChibiOS patches, and also external dependencies on littlefs
    and OpenCCSDS.
  • I tried to keep modified files to a minimum but do note sensors.h,
    can_hw.h, and the app_adcs Makefile.

Copy link
Member

@ryanpdx ryanpdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also prune the L4 apps as we don't use the L4 anymore.

Can also clear the following boards:

  • Board template F4
  • Board template L4
  • ACS v4
  • RWB v4
  • F042K6
  • L452RE_P

We also could keep and fix sensors.[c/h]. I think it is still relevant to F0?

-150k loc. Moving from OreSat0 to OreSat0.5 saw significant hardware
changes that until this point hadn't been reflected in this repo. This
commit removes support for the no longer used hardware, including old
boards, drivers for no longer used devices, and STM32F4/L4
microcontrollers entirely. Of note:

- The archive is gone. Its contents, like the rest of the removals here
  can be accessed in git history.
- The C3 is now Linux based. Removing the old project means we can drop
  our custom ChibiOS patches, and also external dependencies on littlefs
  and OpenCCSDS.
- I tried to keep modified files to a minimum but do note sensors.h,
  can_hw.h, and the app_adcs Makefile.
@ThirteenFish
Copy link
Contributor Author

We also could keep and fix sensors.[c/h]. I think it is still relevant to F0?

I've added it back in, but it'll need some work to get it functional again. The way it's currently implemented it steps on the toes of anyone trying to use the ADC, currently ADCS and the diode card.

@glennl
Copy link
Member

glennl commented Jul 14, 2024

For RF hardware things I occasionally use for testing with an F4 Nucleo, there are three (3) branches I go to. This stuff could possibly be moved somewhere that makes better sense, particularly since the code was initially created before there was any real working C3, but for some reason became part of oresat-firmware repo.

The names of the branches under oresat-firmware are:

  • c3_synth
  • c3_rf
  • c3_L_test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

3 participants