Makes possible to attach additional or replace default security groups to subnets #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for subnets. Previously worked only with default security group Signed-off-by: janis.orlovs <[email protected]>
|
Hello, Any options to merge this? |
|
Hi @JanisOrlovs, Very sorry for the delay. |
|
Hello, |
|
Hello, |
|
Hello, |
|
Hi @JanisOrlovs - I'm very sorry for the delay. I'm reviewing your submission now and will provide feedback in the next couple of days |
snafuz
requested changes
Sep 14, 2022
| @@ -0,0 +1,3 @@ | |||
| data "oci_core_vcn" "vcn_this" { | |||
There was a problem hiding this comment.
this datasource is not used anywhere and should be removed
| @@ -102,4 +102,5 @@ attached_drg_id = null | |||
| #subnets = { | |||
| # sub1 = {name = "subnet1",cidr_block = "10.0.4.0/24"} | |||
| # sub2 = {cidr_block="10.0.5.0/24",type="private"} | |||
| # sub3 = {cidr_block="10.0.6.0/24",type="private", security_list_ids=["ocid1.securitylist.oc1.eu-frankfurt-1.aaaa","ocid1.securitylist.oc1.eu-frankfurt-1.bbbb"]} | |||
There was a problem hiding this comment.
The subnet module is a submodule of vcn module. The security list must be created inside the VCN to be assigned to any subnet. Hence you can not have security lists created previous to the VCN itself. How do you intend to use this feature in a real scenario?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes possible to attach additional or replace default security groups to subnets
Previously worked only with the default security group
Signed-off-by: janis.orlovs [email protected]
Proposed change
Makes possible to attach additional or replace default security groups to subnets
Previously worked only with the default security group
How has these changes been tested?
Test deployments works on my location
Automated testing
NA
Manual testing
If no automated testing is run, please ensure that at least the three steps below are passing without any error.
Checklist before submitting your PR
Note: If you are not an Oracle employee, to contribute to an Oracle-sponsored open-source project, you need to sign the Oracle Contributor Agreement (OCA).