Support setting "priority" in Icinga 2 integration #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 11, 2019 21:01
Add a parameter to set the priority of an alert in the Icinga 2 intergration. This is necessary since host down alerts mostly are of priority P1. refs opsgenie#52 Signed-off-by: Tobias von der Krone <[email protected]>
Use standard golang formatting in the Icinga 2 integration. Signed-off-by: Tobias von der Krone <[email protected]>
tobiasvdk
force-pushed
the
52-add-priority-to-icinga2-integration
branch
from
dfadc73
to
a5eec08
Compare
|
I am wondering why this PR is not merged yet |
|
How can we unblock (this much needed) feature? |
|
Anything we can do to have this merged? |
|
@bkaganyildiz how could we get this merged? It is almost one year old, and really low hanging i think. |
ickiller
added a commit
to ickiller/opsgenie-integration
that referenced
this pull request
Mar 30, 2022
Based on similar pull request for Iciniga 2 integration by tobiasvdk: opsgenie#53 (not sure if it wouldn't be better to fail than only log if validation of specified priority fails)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a parameter to set the priority of an alert in the Icinga 2
intergration. This is necessary since host down alerts mostly
are of priority P1.
refs #52
Signed-off-by: Tobias von der Krone [email protected]