Add OAuth application flow for builtin mobile app #30300
reviewdog [rubocop] report
reported by reviewdog 🐶
Findings (0)
Filtered Findings (24)
app/controllers/admin/settings/project_custom_fields_controller.rb|126 col 7| Redundant else
-clause.
app/controllers/admin/settings/project_custom_fields_controller.rb|141 col 7| Redundant else
-clause.
app/controllers/oauth/applications_controller.rb|81 col 9| Use flash.now
before render
.
app/models/permitted_params.rb|343 col 3| Assignment Branch Condition size for enumerations is too high. [<8, 29, 6> 30.68/17]
app/models/permitted_params.rb|352 col 7| Use each_key
instead of each
and remove the unused _value
block argument.
app/models/permitted_params.rb|365 col 7| Use each_key
instead of each
and remove the unused _value
block argument.
app/models/permitted_params.rb|405 col 5| Use each_value
instead of each
and remove the unused _
block argument.
app/models/permitted_params.rb|422 col 3| protected
(on line 397) does not make singleton methods protected. Use protected
inside a class << self
block instead.
app/models/permitted_params.rb|423 col 5| Memoized variable @whitelisted_params
does not match method name permitted_attributes
. Use @permitted_attributes
instead.
app/models/permitted_params.rb|643 col 3| protected
(on line 397) does not make singleton methods protected. Use protected
inside a class << self
block instead.
modules/storages/app/services/storages/storages/update_service.rb|35 col 7| Call super
without arguments and parentheses when the signature is identical.
spec/controllers/oauth/applications_controller_spec.rb|32 col 1| Spec path should end with o_auth/applications_controller*_spec.rb
.
spec/controllers/oauth/applications_controller_spec.rb|40 col 11| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/controllers/oauth/applications_controller_spec.rb|67 col 7| Prefer expect(response).to have_http_status(200)
over expect(response.status).to be 200
.
spec/controllers/oauth/applications_controller_spec.rb|82 col 7| Prefer expect(response).to have_http_status(200)
over expect(response.status).to be 200
.
spec/controllers/oauth/applications_controller_spec.rb|107 col 7| Do not use expect
in before
hook
spec/controllers/oauth/applications_controller_spec.rb|107 col 35| Prefer have_received
for setting message expectations. Setup application_stub
as a spy using allow
or instance_spy
.
spec/controllers/oauth/applications_controller_spec.rb|108 col 7| Do not use expect
in before
hook
spec/controllers/oauth/applications_controller_spec.rb|108 col 7| Prefer allow
over expect
when configuring a response.
spec/controllers/oauth/applications_controller_spec.rb|108 col 35| Prefer have_received
for setting message expectations. Setup application_stub
as a spy using allow
or instance_spy
.
spec/controllers/oauth/applications_controller_spec.rb|123 col 7| Do not use expect
in before
hook
spec/controllers/oauth/applications_controller_spec.rb|123 col 7| Prefer allow
over expect
when configuring a response.
spec/controllers/oauth/applications_controller_spec.rb|123 col 35| Prefer have_received
for setting message expectations. Setup application_stub
as a spy using allow
or instance_spy
.
spec/features/oauth/authorization_code_flow_spec.rb|122 col 131| Line is too long. [162/130]