Skip to content

Remove AuthSource base namespace, model #10939

Remove AuthSource base namespace, model

Remove AuthSource base namespace, model #10939

GitHub Actions / rubocop failed Jul 26, 2023 in 1s

reviewdog [rubocop] report

reported by reviewdog 🐶

Findings (2)

app/components/ldap_auth_sources/row_component.rb|37 col 5| [Correctable] Rails/Delegate: Use delegate to define delegations.
app/components/ldap_auth_sources/table_component.rb|59 col 59| [Correctable] Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array.

Filtered Findings (377)

app/controllers/account_controller.rb|77 col 3| Metrics/AbcSize: Assignment Branch Condition size for lost_password is too high. [<8, 51, 13> 53.24/17]
app/controllers/account_controller.rb|77 col 3| Metrics/PerceivedComplexity: Perceived complexity for lost_password is too high. [15/8]
app/controllers/account_controller.rb|81 col 16| [Correctable] Rails/DynamicFindBy: Use find_by instead of dynamic find_by_plaintext_value.
app/controllers/account_controller.rb|99 col 14| [Correctable] Rails/DynamicFindBy: Use find_by instead of dynamic find_by_mail.
app/controllers/account_controller.rb|163 col 13| [Correctable] Rails/DynamicFindBy: Use find_by instead of dynamic find_by_plaintext_value.
app/controllers/account_controller.rb|173 col 5| Lint/DuplicateBranch: Duplicate branch body detected.
app/controllers/account_controller.rb|191 col 3| Metrics/AbcSize: Assignment Branch Condition size for activate_self_registered is too high. [<5, 24, 7> 25.5/17]
app/controllers/account_controller.rb|273 col 3| Metrics/AbcSize: Assignment Branch Condition size for auth_source_sso_failed is too high. [<4, 22, 1> 22.38/17]
app/controllers/account_controller.rb|284 col 25| [Correctable] Style/StringConcatenation: Prefer string interpolation to string concatenation.
app/controllers/account_controller.rb|293 col 26| [Correctable] Rails/Blank: Use if session[:auth_source_sso_failure].blank? instead of unless session[:auth_source_sso_failure].present?.
app/controllers/account_controller.rb|339 col 3| Metrics/AbcSize: Assignment Branch Condition size for register_plain_user is too high. [<5, 24, 3> 24.7/17]
app/controllers/account_controller.rb|354 col 3| Metrics/AbcSize: Assignment Branch Condition size for register_with_auth_source is too high. [<3, 20, 2> 20.32/17]
app/controllers/account_controller.rb|386 col 3| Metrics/AbcSize: Assignment Branch Condition size for direct_login is too high. [<5, 16, 5> 17.49/17]
app/controllers/account_controller.rb|412 col 3| Metrics/AbcSize: Assignment Branch Condition size for password_authentication is too high. [<2, 27, 14> 30.48/17]
app/controllers/account_controller.rb|412 col 3| Metrics/PerceivedComplexity: Perceived complexity for password_authentication is too high. [15/8]
app/controllers/account_controller.rb|416 col 14| [Correctable] Rails/DynamicFindBy: Use find_by instead of dynamic find_by_login.
app/controllers/account_controller.rb|417 col 10| [Correctable] Style/SafeNavigation: Use safe navigation (&.) instead of checking if an object exists before calling the method.
app/controllers/account_controller.rb|433 col 13| [Correctable] Style/SafeNavigation: Use safe navigation (&.) instead of checking if an object exists before calling the method.
app/controllers/account_controller.rb|510 col 15| [Correctable] Rails/DynamicFindBy: Use find_by instead of dynamic find_by_plaintext_value.
app/controllers/concerns/auth_source_sso.rb|94 col 5| [Correctable] Rails/Blank: Use if login.blank? instead of unless login.present?.
app/controllers/concerns/auth_source_sso.rb|124 col 3| Metrics/AbcSize: Assignment Branch Condition size for create_user_from_auth_source is too high. [<4, 23, 3> 23.54/17]
app/helpers/accounts_helper.rb|8 col 7| Rails/HelperInstanceVariable: Do not use instance variables in helpers.
app/helpers/users_helper.rb|51 col 30| Style/OptionalBooleanParameter: Prefer keyword arguments for arguments with a boolean default value; use include_num_failed_logins: false instead of include_num_failed_logins = false.
app/helpers/users_helper.rb|76 col 27| [Correctable] Style/MutableConstant: Freeze mutable objects assigned to constants.
app/models/ldap_auth_source.rb|266 col 23| Naming/MethodParameterName: Method parameter must be at least 3 characters long.
app/models/ldap_auth_source.rb|299 col 3| Lint/IneffectiveAccessModifier: private (on line 212) does not make singleton methods private. Use private_class_method or private inside a class << self block instead.
app/models/permitted_params.rb|74 col 30| [Correctable] Style/ReturnNilInPredicateMethodDefinition: Return false instead of nil in predicate methods.
app/models/permitted_params.rb|175 col 28| [Correctable] Style/ReturnNilInPredicateMethodDefinition: Return false instead of nil in predicate methods.
app/models/permitted_params.rb|332 col 3| Metrics/AbcSize: Assignment Branch Condition size for enumerations is too high. [<8, 29, 6> 30.68/17]
app/models/permitted_params.rb|411 col 3| Lint/IneffectiveAccessModifier: protected (on line 386) does not make singleton methods protected. Use protected inside a class << self block instead.
app/models/permitted_params.rb|412 col 5| [Correctable] Naming/MemoizedInstanceVariableName: Memoized variable @whitelisted_params does not match method name permitted_attributes. Use @permitted_attributes instead.
app/models/permitted_params.rb|621 col 3| Lint/IneffectiveAccessModifier: protected (on line 386) does not make singleton methods protected. Use protected inside a class << self block instead.
app/models/user.rb|46 col 3| Rails/InverseOf: Specify an :inverse_of option.
app/models/user.rb|67 col 3| Rails/HasManyOrHasOneDependent: Specify a :dependent option.
app/models/user.rb|67 col 3| Rails/InverseOf: Specify an :inverse_of option.
app/models/user.rb|72 col 3| Rails/HasManyOrHasOneDependent: Specify a :dependent option.
app/models/user.rb|102 col 35| [Correctable] Rails/TimeZone: Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.xmlschema, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.httpdate, Time.now.to_i, Time.now.to_f instead.
app/models/user.rb|209 col 3| Metrics/PerceivedComplexity: Perceived complexity for try_authentication_for_existing_user is too high. [10/8]
app/models/user.rb|228 col 15| [Correctable] Rails/DynamicFindBy: Use find_by instead of dynamic find_by_plaintext_value.
app/models/user.rb|264 col 13| [Correctable] Rails/DynamicFindBy: Use find_by instead of dynamic find_by_plaintext_value.
app/models/user.rb|283 col 5| Lint/DuplicateBranch: Duplicate branch body detected.
app/models/user.rb|383 col 43| [Correctable] Rails/TimeZone: Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.xmlschema, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.httpdate, Time.now.to_i, Time.now.to_f instead.
app/models/user.rb|411 col 13| [Correctable] Rails/DynamicFindBy: Use find_by instead of dynamic find_by_plaintext_value.
app/models/user.rb|455 col 12| [Correctable] Rails/Date: Do not use Date.today without zone. Use Time.zone.today instead.
app/models/user.rb|544 col 3| Metrics/AbcSize: Assignment Branch Condition size for anonymous is too high. [<9, 15, 3> 17.75/17]
app/models/user.rb|613 col 3| Lint/IneffectiveAccessModifier: private (on line 611) does not make singleton methods private. Use private_class_method or private inside a class << self block instead.
app/models/user.rb|642 col 16| [Correctable] Style/SlicingWithRange: Prefer ary[n..] over ary[n..-1].
app/models/user.rb|652 col 3| Lint/IneffectiveAccessModifier: private (on line 611) does not make singleton methods private. Use private_class_method or private inside a class << self block instead.
app/models/user.rb|660 col 3| Lint/IneffectiveAccessModifier: private (on line 611) does not make singleton methods private. Use private_class_method or private inside a class << self block instead.
app/models/user.rb|661 col 12| [Correctable] Rails/DynamicFindBy: Use find_by instead of dynamic find_by_login.
app/models/user.rb|666 col 3| Lint/IneffectiveAccessModifier: private (on line 611) does not make singleton methods private. Use private_class_method or private inside a class << self block instead.
app/models/user.rb|670 col 3| Lint/IneffectiveAccessModifier: private (on line 611) does not make singleton methods private. Use private_class_method or private inside a class << self block instead.
app/models/user.rb|686 col 12| [Correctable] Rails/TimeZone: Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.xmlschema, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.httpdate, Time.now.to_i, Time.now.to_f instead.
app/models/user.rb|698 col 38| [Correctable] Rails/TimeZone: Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.xmlschema, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.httpdate, Time.now.to_i, Time.now.to_f instead.
app/models/user.rb|701 col 3| Lint/IneffectiveAccessModifier: private (on line 611) does not make singleton methods private. Use private_class_method or private inside a class << self block instead.
app/models/user.rb|702 col 6| [Correctable] Rails/DynamicFindBy: Use find_by instead of dynamic find_by_login.
config/routes.rb|86 col 37| [Correctable] Layout/ExtraSpacing: Unnecessary spacing detected.
db/migrate/20180419061910_timestamp_for_caching.rb|47 col 39| [Correctable] Rails/TimeZone: Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.xmlschema, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.httpdate, Time.now.to_i, Time.now.to_f instead.
db/migrate/20180419061910_timestamp_for_caching.rb|47 col 61| [Correctable] Rails/TimeZone: Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.xmlschema, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.httpdate, Time.now.to_i, Time.now.to_f instead.
db/migrate/20221026132134_bigint_primary_and_foreign_keys.rb|29 col 19| [Correctable] Style/RedundantCurrentDirectoryInPath: Remove the redundant current directory path.
modules/ldap_groups/app/controllers/ldap_groups/synchronized_filters_controller.rb|62 col 9| [Correctable] Rails/ActionControllerFlashBeforeRender: Use flash.now before render.
modules/ldap_groups/app/controllers/ldap_groups/synchronized_filters_controller.rb|66 col 9| [Correctable] Rails/ActionControllerFlashBeforeRender: Use flash.now before render.
modules/ldap_groups/app/services/ldap_groups/synchronization_service.rb|9 col 5| Metrics/AbcSize: Assignment Branch Condition size for call is too high. [<4, 19, 1> 19.44/17]
modules/ldap_groups/app/services/ldap_groups/synchronize_filter_service.rb|71 col 37| Naming/MethodParameterName: Method parameter must be at least 3 characters long.
modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb|20 col 9| [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(403) over expect(response.status).to eq 403.
modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb|41 col 9| [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(403) over expect(response.status).to eq 403.
modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb|53 col 11| [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(404) over expect(response.status).to eq(404).
modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb|62 col 11| RSpec/StubbedMock: Prefer allow over expect when configuring a response.
modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb|63 col 19| RSpec/MessageSpies: Prefer have_received for setting message expectations. Setup LdapGroups::SynchronizedGroup as a spy using allow or instance_spy.
modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb|81 col 9| [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(403) over expect(response.status).to eq 403.
modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb|100 col 7| RSpec/AnyInstance: Avoid stubbing using allow_any_instance_of.
modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb|109 col 9| [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(403) over expect(response.status).to eq 403.
modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb|120 col 11| [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(400) over expect(response.status).to eq(400).
modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb|138 col 13| [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(200) over expect(response.status).to eq(200).
modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb|153 col 9| [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(403) over expect(response.status).to eq 403.
modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb|165 col 11| [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(404) over expect(response.status).to eq(404).
modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb|174 col 11| RSpec/StubbedMock: Prefer allow over expect when configuring a response.
modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb|175 col 19| RSpec/MessageSpies: Prefer have_received for setting message expectations. Setup LdapGroups::SynchronizedGroup as a spy using allow or instance_spy.
modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb|194 col 9| [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(403) over expect(response.status).to eq 403.
modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb|206 col 11| [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(404) over expect(response.status).to eq(404).
modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb|215 col 11| RSpec/ExpectInHook: Do not use expect in before hook
modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb|215 col 11| RSpec/StubbedMock: Prefer allow over expect when configuring a response.
modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb|216 col 19| RSpec/MessageSpies: Prefer have_received for setting message expectations. Setup LdapGroups::SynchronizedGroup as a spy using allow or instance_spy.
modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb|220 col 11| RSpec/ExpectInHook: Do not use expect in before hook
modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb|220 col 11| RSpec/StubbedMock: Prefer allow over expect when configuring a response.
modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb|221 col 17| RSpec/MessageSpies: Prefer have_received for setting message expectations. Setup group as a spy using allow or instance_spy.
modules/ldap_groups/spec/models/synchronized_group_spec.rb|7 col 13| RSpec/ContextWording: Context description should match /^and\b/, /^as\b/, /^for\b/, /^having\b/, /^if\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
modules/ldap_groups/spec/models/synchronized_group_spec.rb|13 col 13| RSpec/ContextWording: Context description should match /^and\b/, /^as\b/, /^for\b/, /^having\b/, /^if\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
modules/ldap_groups/spec/models/synchronized_group_spec.rb|27 col 5| RSpec/IndexedLet: This let statement uses index in its name. Please give it a meaningful name.
modules/ldap_groups/spec/models/synchronized_group_spec.rb|28 col 5| RSpec/IndexedLet: This let statement uses index in its name. Please give it a meaningful name.
modules/ldap_groups/spec/models/synchronized_group_spec.rb|38 col 11| RSpec/ExpectInHook: Do not use expect in before hook
modules/ldap_groups/spec/models/synchronized_group_spec.rb|39 col 11| RSpec/ExpectInHook: Do not use expect in before hook
modules/ldap_groups/spec/models/synchronized_group_spec.rb|55 col 15| RSpec/ContextWording: Context description should match /^and\b/, /^as\b/, /^for\b/, /^having\b/, /^if\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
modules/ldap_groups/spec/models/synchronized_group_spec.rb|61 col 15| RSpec/ContextWording: Context description should match /^and\b/, /^as\b/, /^for\b/, /^having\b/, /^if\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
modules/ldap_groups/spec/models/synchronized_group_spec.rb|98 col 15| RSpec/ContextWording: Context description should match /^and\b/, /^as\b/, /^for\b/, /^having\b/, /^if\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
modules/ldap_groups/spec/models/synchronized_group_spec.rb|104 col 15| RSpec/ContextWording: Context description should match /^and\b/, /^as\b/, /^for\b/, /^having\b/, /^if\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
modules/ldap_groups/spec/services/synchronization_spec.rb|1 col 9| [Correctable] Style/StringConcatenation: Prefer string interpolation to string concatenation.
modules/ldap_groups/spec/services/synchronization_spec.rb|126 col 13| RSpec/ExpectInHook: Do not use expect in before hook
modules/ldap_groups/spec/services/synchronization_spec.rb|127 col 13| RSpec/ExpectInHook: Do not use expect in before hook
modules/ldap_groups/spec/services/synchronization_spec.rb|129 col 13| RSpec/ExpectInHook: Do not use expect in before hook
modules/ldap_groups/spec/services/synchronization_spec.rb|130 col 13| RSpec/ExpectInHook: Do not use expect in before hook
modules/ldap_groups/spec/services/synchronization_spec.rb|145 col 19| [Correctable] RSpec/ExpectChange: Prefer change(LdapGroups::Membership, :count).
modules/ldap_groups/spec/services/synchronization_spec.rb|158 col 19| [Correctable] RSpec/MatchArray: Prefer contain_exactly when matching an array literal.
modules/ldap_groups/spec/services/synchronization_spec.rb|279 col 13| RSpec/ContextWording: Context description should match /^and\b/, /^as\b/, /^for\b/, /^having\b/, /^if\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
modules/ldap_groups/spec/services/synchronize_filter_spec.rb|1 col 9| [Correctable] Style/StringConcatenation: Prefer string interpolation to string concatenation.
modules/ldap_groups/spec/services/synchronize_filter_spec.rb|5 col 3| RSpec/BeforeAfterAll: Beware of using before(:all) as it may cause state to leak between tests. If you are using rspec-rails, and use_transactional_fixtures is enabled, then records created in before(:all) are not automatically rolled back.
modules/ldap_groups/spec/services/synchronize_filter_spec.rb|11 col 3| RSpec/BeforeAfterAll: Beware of using after(:all) as it may cause state to leak between tests. If you are using rspec-rails, and use_transactional_fixtures is enabled, then records created in after(:all) are not automatically rolled back.
modules/ldap_groups/spec/services/synchronize_filter_spec.rb|12 col 5| RSpec/InstanceVariable: Avoid instance variables – use let, a method call, or a local variable (if possible).
modules/ldap_groups/spec/services/synchronize_filter_spec.rb|59 col 50| [Correctable] RSpec/MatchArray: Prefer contain_exactly when matching an array literal.
modules/two_factor_authentication/spec/models/user_spec.rb|12 col 9| RSpec/AnyInstance: Avoid stubbing using allow_any_instance_of.
modules/two_factor_authentication/spec/models/user_spec.rb|25 col 31| [Correctable] Style/StringConcatenation: Prefer string interpolation to string concatenation.
spec/controllers/account_controller_spec.rb|33 col 3| Lint/ConstantDefinitionInBlock: Do not define constants this way within a block.
spec/controllers/account_controller_spec.rb|33 col 3| RSpec/LeakyConstantDeclaration: Stub class constant instead of declaring explicitly.
spec/controllers/account_controller_spec.rb|57 col 11| RSpec/ContextWording: Context description should match /^and\b/, /^as\b/, /^for\b/, /^having\b/, /^if\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/controllers/account_controller_spec.rb|58 col 5| Lint/EmptyBlock: Empty block detected.
spec/controllers/account_controller_spec.rb|72 col 13| RSpec/ContextWording: Context description should match /^and\b/, /^as\b/, /^for\b/, /^having\b/, /^if\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/controllers/account_controller_spec.rb|81 col 13| RSpec/ContextWording: Context description should match /^and\b/, /^as\b/, /^for\b/, /^having\b/, /^if\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/controllers/account_controller_spec.rb|91 col 13| RSpec/ContextWording: Context description should match /^and\b/, /^as\b/, /^for\b/, /^having\b/, /^if\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/controllers/account_controller_spec.rb|127 col 11| RSpec/ContextWording: Context description should match /^and\b/, /^as\b/, /^for\b/, /^having\b/, /^if\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/controllers/account_controller_spec.rb|246 col 67| RSpec/InstanceVariable: Avoid instance variables – use let, a method call, or a local variable (if possible).
spec/controllers/account_controller_spec.rb|311 col 13| RSpec/ContextWording: Context description should match /^and\b/, /^as\b/, /^for\b/, /^having\b/, /^if\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/controllers/account_controller_spec.rb|315 col 16| RSpec/InstanceVariable: Avoid instance variables – use let, a method call, or a local variable (if possible).
spec/controllers/account_controller_spec.rb|315 col 32| RSpec/MessageSpies: Prefer have_received for setting message expectations. Setup @controller as a spy using allow or instance_spy.
spec/controllers/account_controller_spec.rb|417 col 9| [Correctable] RSpec/PredicateMatcher: Prefer using be_anonymous matcher over anonymous?.
spec/controllers/account_controller_spec.rb|417 col 16| RSpec/InstanceVariable: Avoid instance variables – use let, a method call, or a local variable (if possible).
spec/controllers/account_controller_spec.rb|429 col 9| [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(404) over expect(response.status).to eq 404.
spec/controllers/account_controller_spec.rb|453 col 9| RSpec/AnyInstance: Avoid stubbing using allow_any_instance_of.
spec/controllers/account_controller_spec.rb|500 col 7| RSpec/AnyInstance: Avoid stubbing using allow_any_instance_of.
spec/controllers/account_controller_spec.rb|518 col 9| [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(404) over expect(response.status).to eq 404.
spec/controllers/account_controller_spec.rb|558 col 9| [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(404) over expect(response.status).to eq 404.
spec/controllers/account_controller_spec.rb|577 col 11| RSpec/ContextWording: Context description should match /^and\b/, /^as\b/, /^for\b/, /^having\b/, /^if\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/controllers/account_controller_spec.rb|632 col 11| RSpec/ContextWording: Context description should match /^and\b/, /^as\b/, /^for\b/, /^having\b/, /^if\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/controllers/account_controller_spec.rb|718 col 60| Lint/ShadowingOuterLocalVariable: Shadowing outer local variable - mail.
spec/controllers/account_controller_spec.rb|764 col 18| [Correctable] Rails/DynamicFindBy: Use find_by instead of dynamic find_by_login.
spec/controllers/account_controller_spec.rb|810 col 18| [Correctable] Rails/DynamicFindBy: Use find_by instead of dynamic find_by_login.
spec/controllers/account_controller_spec.rb|871 col 9| RSpec/AnyInstance: Avoid stubbing using allow_any_instance_of.
spec/controllers/account_controller_spec.rb|896 col 18| [Correctable] Rails/DynamicFindBy: Use find_by instead of dynamic find_by_login.
spec/controllers/account_controller_spec.rb|915 col 13| [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(404) over expect(response.status).to eq 404.
spec/controllers/account_controller_spec.rb|937 col 11| RSpec/ContextWording: Context description should match /^and\b/, /^as\b/, /^for\b/, /^having\b/, /^if\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/controllers/account_controller_spec.rb|963 col 56| Lint/ShadowingOuterLocalVariable: Shadowing outer local variable - mail.
spec/controllers/account_controller_spec.rb|969 col 13| RSpec/ContextWording: Context description should match /^and\b/, /^as\b/, /^for\b/, /^having\b/, /^if\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/controllers/account_controller_spec.rb|975 col 13| RSpec/ContextWording: Context description should match /^and\b/, /^as\b/, /^for\b/, /^having\b/, /^if\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/controllers/concerns/omniauth_login_spec.rb|34 col 29| RSpec/VerifiedDoubles: Prefer using verifying doubles over normal doubles.
spec/controllers/concerns/omniauth_login_spec.rb|56 col 11| RSpec/ContextWording: Context description should match /^and\b/, /^as\b/, /^for\b/, /^having\b/, /^if\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/controllers/concerns/omniauth_login_spec.rb|58 col 15| RSpec/ContextWording: Context description should match /^and\b/, /^as\b/, /^for\b/, /^having\b/, /^if\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/controllers/concerns/omniauth_login_spec.rb|65 col 18| [Correctable] Rails/DynamicFindBy: Use find_by instead of dynamic find_by_login.
spec/controllers/concerns/omniauth_login_spec.rb|99 col 18| [Correctable] Rails/DynamicFindBy: Use find_by instead of dynamic find_by_login.
spec/controllers/concerns/omniauth_login_spec.rb|122 col 17| RSpec/ContextWording: Context description should match /^and\b/, /^as\b/, /^for\b/, /^having\b/, /^if\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/controllers/concerns/omniauth_login_spec.rb|133 col 42| RSpec/MessageSpies: Prefer have_received for setting message expectations. Setup omniauth_strategy as a spy using allow or instance_spy.
spec/controllers/concerns/omniauth_login_spec.rb|137 col 20| [Correctable] Rails/DynamicFindBy: Use find_by instead of dynamic find_by_login.
... (Too many findings. Dropped some findings)

Annotations

Check failure on line 37 in app/components/ldap_auth_sources/row_component.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] app/components/ldap_auth_sources/row_component.rb#L37

[Correctable] Rails/Delegate: Use delegate to define delegations.
Raw output
app/components/ldap_auth_sources/row_component.rb:37:5: C: [Correctable] Rails/Delegate: Use delegate to define delegations.
    def host
    ^^^

Check failure on line 59 in app/components/ldap_auth_sources/table_component.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] app/components/ldap_auth_sources/table_component.rb#L59

[Correctable] Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array.
Raw output
app/components/ldap_auth_sources/table_component.rb:59:59: C: [Correctable] Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array.
        ['users', { caption: I18n.t(:label_user_plural) }],
                                                          ^