Feature/46309 Custom field no longer added to all projects when added to a type #17044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulferts
force-pushed
the
feature/46309-custom-field-no-longer-added-to-all-projects-when-added-to-a-type
branch
from
1a3a5bd
to
2472544
Compare
ulferts
commented
Oct 25, 2024
Comment on lines
+168
to
+182
| type.custom_field_ids = type | ||
| .attribute_groups | ||
| .flat_map(&:members) | ||
| .select { CustomField.custom_field_attribute? _1 } | ||
| .map { _1.gsub(/^custom_field_/, "").to_i } | ||
| .uniq | ||
| end | ||
|
|
||
| def active_custom_field_ids | ||
| @active_custom_field_ids ||= begin | ||
| active_cf_ids = [] | ||
|
|
||
| type.attribute_groups.each do |group| | ||
| group.members.each do |attribute| | ||
| if CustomField.custom_field_attribute? attribute | ||
| active_cf_ids << attribute.gsub(/^custom_field_/, "").to_i | ||
| end | ||
| end | ||
| end | ||
| active_cf_ids.uniq | ||
| end | ||
| end | ||
| def set_active_custom_fields_for_project_ids(project_ids) | ||
| new_project_ids_to_activate_cfs = project_ids.reject(&:empty?).map(&:to_i) - type.project_ids | ||
|
|
||
| def set_active_custom_fields_for_projects(projects, custom_field_ids) | ||
| values = projects | ||
| values = Project | ||
| .where(id: new_project_ids_to_activate_cfs) | ||
| .to_a | ||
| .product(custom_field_ids) | ||
| .product(type.custom_field_ids) |
There was a problem hiding this comment.
The code's functionality wasn't changed. It was just cleaned up after having less callers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/46309
What are you trying to accomplish?
Adding a custom field to a type no longer adds it to all the projects the type is active in.
When adding a project to a type, though, will add all custom fields to the project.
Merge checklist