Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug turbo events in development #16706

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Debug turbo events in development #16706

merged 1 commit into from
Sep 11, 2024

Conversation

oliverguenther
Copy link
Member

In development mode, output all turbo events to console so we can observe what happens during navigation

Copy link
Member

@cbliard cbliard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cbliard cbliard merged commit 3a0662b into dev Sep 11, 2024
12 checks passed
@cbliard cbliard deleted the chore/turbo-debug-events branch September 11, 2024 12:03
Comment on lines +2 to +16
'turbo:click',
'turbo:before-visit',
'turbo:visit',
'turbo:submit-start',
'turbo:before-fetch-request',
'turbo:before-fetch-response',
'turbo:submit-end',
'turbo:before-cache',
'turbo:before-render',
'turbo:before-stream-render',
'turbo:render',
'turbo:load',
'turbo:frame-render',
'turbo:frame-load',
'turbo:fetch-request-error',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to sort alphabetically

Also why not all events, maybe turbo:before-morph-element, turbo:before-morph-attribute andturbo:morph-element will spam, and turbo:frame-missing will be visible anyway, but why not turbo:morph, turbo:before-frame-morph, turbo:before-frame-render, turbo:before-prefetch, turbo:reload?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add them 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants