[#57037] Migrate UserPreference settings with the "default" theme to "light" #16676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missed when upgrading OpenProject at some point so this should bring everything back in order for users that still have the "default" theme setting which is no longer supported, and keep the preferences for said users who have since moved to one of the valid optionsl like "light" or "light_high_contrast".
toy
requested changes
Sep 9, 2024
db/migrate/20240909151818_migrate_legacy_default_theme_to_light_theme.rb
Outdated
Show resolved
Hide resolved
db/migrate/20240909151818_migrate_legacy_default_theme_to_light_theme.rb
Outdated
Show resolved
Hide resolved
spec/migrations/migrate_legacy_default_theme_to_light_theme_spec.rb
Outdated
Show resolved
Hide resolved
|
The provided work package version does not match the core version:
Please make sure that:
|
toy
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/work_packages/57037
What are you trying to accomplish?
A lot of areas were broken display-wise when upgrading from 9.x versions. This happened if users still had in their
UserPreferencetheme settings thedefaultoption. I'm bringing these "default" values to "light" which is the current default setting for the theme setting.Screenshots
Before
After
What approach did you choose and why?
This was missed when upgrading OpenProject at some point so this should bring everything back in order for users that still have the "default" theme setting which is no longer supported, and keep the preferences for said users who have since moved to one of the valid options like "light" or "light_high_contrast".
A migration should suffice.
Merge checklist