Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#55234] Fix text filter width on project list #16653

Conversation

dombesz
Copy link
Contributor

@dombesz dombesz commented Sep 6, 2024

Ticket

https://community.openproject.org/work_packages/55234

What are you trying to accomplish?

Add a larger width to the project list search input.

Screenshots

image

What approach did you choose and why?

Added an override for the project list input filter, because the primer provided css was not working.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@dombesz dombesz requested a review from a team September 6, 2024 17:04
@dombesz dombesz force-pushed the feature/55234-always-visible-text-filter-in-project-list branch from 39622e2 to 98fd24b Compare September 6, 2024 17:04
@HDinger HDinger force-pushed the feature/55234-always-visible-text-filter-in-project-list branch from 98fd24b to 4efeb7a Compare September 9, 2024 06:31
Copy link
Contributor

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current solution is weird, as the override is basically setting the width and not the input_width which should be responsible for it. We should fix it in the primer repo as soon as possible. Due to the time pressure, I am fine with merging this for now.

@dombesz dombesz marked this pull request as ready for review September 9, 2024 07:32
@HDinger HDinger merged commit ad575e0 into release/14.5 Sep 9, 2024
7 checks passed
@HDinger HDinger deleted the feature/55234-always-visible-text-filter-in-project-list branch September 9, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants