Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[57644] Column ordering broken on project list #16646

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

bsatarnejad
Copy link
Contributor

@bsatarnejad bsatarnejad commented Sep 6, 2024

Ticket

https://community.openproject.org/projects/openproject/work_packages/57644/activity

What are you trying to accomplish?

Fix draggable columns inside configure view modal of projects list to work correctly.

Screenshots

Before:
https://github.com/user-attachments/assets/9f6b767f-bc89-4732-a8ed-3ed00f19d88e

After:
https://github.com/user-attachments/assets/6820fcf7-76d1-4cd3-8a4a-804b0358b6c9

What approach did you choose and why?

When the component is inside a Primer dialog component and isn't append to the body, it should have formControlId and dragAreaName inputs' values.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, Safari)

Copy link
Contributor

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to have the id in a variable, so that it still works whenever I change the id.

e.g

id: COLUMN_HTML_ID,
dragAreaName: "#{COLUMN_HTML_ID}_dragarea",
formControlId: "#{COLUMN_HTML_ID}_autocompleter",

Copy link
Contributor

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge once the tests are green

@ulferts ulferts merged commit 1e067bb into release/14.5 Sep 6, 2024
10 checks passed
@ulferts ulferts deleted the 57644-column-ordering-broken-on-project-list branch September 6, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants