Feature/57347 add validation connection check unexpected content for nextcloud storages #16645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfohl
force-pushed
the
feature/57347-add-validation-connection-check-unexpected-content-for-nextcloud-storages
branch
from
3647d2e
to
5820470
Compare
Kharonus
requested changes
Sep 6, 2024
modules/storages/app/common/storages/peripherals/nextcloud_connection_validator.rb
Show resolved
Hide resolved
modules/storages/app/common/storages/peripherals/nextcloud_connection_validator.rb
Outdated
Show resolved
Hide resolved
modules/storages/spec/common/storages/peripherals/nextcloud_connection_validator_spec.rb
Outdated
Show resolved
Hide resolved
apfohl
force-pushed
the
feature/57347-add-validation-connection-check-unexpected-content-for-nextcloud-storages
branch
3 times, most recently
from
21e5536
to
489411a
Compare
Kharonus
reviewed
Sep 12, 2024
modules/storages/app/common/storages/peripherals/nextcloud_connection_validator.rb
Show resolved
Hide resolved
apfohl
force-pushed
the
feature/57347-add-validation-connection-check-unexpected-content-for-nextcloud-storages
branch
3 times, most recently
from
139ba0c
to
7e69f1a
Compare
apfohl
force-pushed
the
feature/57347-add-validation-connection-check-unexpected-content-for-nextcloud-storages
branch
from
839d67b
to
ee5141f
Compare
apfohl
force-pushed
the
feature/57347-add-validation-connection-check-unexpected-content-for-nextcloud-storages
branch
from
ee5141f
to
6cd2071
Compare
apfohl
deleted the
feature/57347-add-validation-connection-check-unexpected-content-for-nextcloud-storages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/openproject/work_packages/57347/github
What are you trying to accomplish?
Adding a validator for the
NextcloudConnectionValidationthat checks for unforseen folder contents inside the group folder on Nextcloud side.What approach did you choose and why?
I just programmed it!
Merge checklist