Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/57508 custom fields with format string text bool link and date dont forbid multi select internally and have handling in ordering #16570

Merged
merged 9 commits into from
Sep 12, 2024
Merged

Bug/57508 custom fields with format string text bool link and date dont forbid multi select internally and have handling in ordering #16570

merged 9 commits into from
Sep 12, 2024

Commits on Sep 10, 2024

  1. [#57508] Custom fields with format string, text, bool, link and date … 

    …don't forbid multi select internally and have handling in ordering

https://community.openproject.org/work_packages/57508
    @toy
    toy committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    bb4f6b3 View commit details
    Browse the repository at this point in the history

  2. it shouldn't be possible to order by text (long text) custom fields

    @toy
    toy committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    960741b View commit details
    Browse the repository at this point in the history

  3. don't handle ordering of multi value custom fields with formats strin… 

    …g, date, bool, link
    @toy
    toy committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    f2d4d99 View commit details
    Browse the repository at this point in the history

  4. no need to explicitly define accessors for multi_value? and allow_non… 

    …_open_versions? of CustomField
    @toy
    toy committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    d89f3bd View commit details
    Browse the repository at this point in the history

  5. simplify condition which uses CustomField#multi_value_possible?, as i… 

    …t already checks for list format
    @toy
    toy committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9382b12 View commit details
    Browse the repository at this point in the history

  6. simplify condition which uses CustomField#allow_non_open_versions_pos… 

    …sible?, as it already checks for version format
    @toy
    toy committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    6badbd8 View commit details
    Browse the repository at this point in the history

  7. validate that multi_value is not set unless multi_value_possible? and… 

    … allow_non_open_versions unless allow_non_open_versions_possible?
    @toy
    toy committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    e0c43c4 View commit details
    Browse the repository at this point in the history

  8. remove custom field class check for multi_value and allow_non_open_ve… 

    …rsions
    @toy
    toy committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    72bff94 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. use separate accessors instead of checking field_format against list … 

    …in CustomField#multi_value_possible?
    @toy
    toy committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    0b859db View commit details
    Browse the repository at this point in the history