Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/56771 meeting timestamp in edit form not the same as in details #16567

Merged
merged 18 commits into from
Sep 26, 2024

move shared function user code into module

cd615f5
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Bug/56771 meeting timestamp in edit form not the same as in details #16567

move shared function user code into module
cd615f5
Select commit
Loading
Failed to load commit list.
GitHub Actions / rubocop failed Sep 24, 2024 in 1s

reviewdog [rubocop] report

reported by reviewdog 🐶

Findings (2)

app/models/user.rb|663 col 3| private (on line 581) does not make singleton methods private. Use private_class_method or private inside a class << self block instead.
modules/meeting/app/models/activities/meeting_activity_provider.rb|101 col 3| Assignment Branch Condition size for event_title is too high. [<5, 20, 3> 20.83/17]

Filtered Findings (0)

Annotations

Check warning on line 663 in app/models/user.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] app/models/user.rb#L663 <Lint/IneffectiveAccessModifier> 

`private` (on line 581) does not make singleton methods private. Use `private_class_method` or `private` inside a `class << self` block instead.
Raw output 
app/models/user.rb:663:3: W: Lint/IneffectiveAccessModifier: `private` (on line 581) does not make singleton methods private. Use `private_class_method` or `private` inside a `class << self` block instead.

Check notice on line 119 in modules/meeting/app/models/activities/meeting_activity_provider.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] modules/meeting/app/models/activities/meeting_activity_provider.rb#L101-L119 <Metrics/AbcSize> 

Assignment Branch Condition size for event_title is too high. [<5, 20, 3> 20.83/17]
Raw output 
modules/meeting/app/models/activities/meeting_activity_provider.rb:101:3: C: Metrics/AbcSize: Assignment Branch Condition size for event_title is too high. [<5, 20, 3> 20.83/17]
View more details on GitHub Actions