Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ProjectQuery to be marked as public #15609
Allow ProjectQuery to be marked as public #15609
Changes from 27 commits
755c3e0
e57eb91
85235de
3768e72
ca6e583
1954629
76f76d6
539e297
e13a8f6
b19d1c0
8a450a4
cb61339
62c9535
6a835f4
282d02b
6988711
438afa8
eef97fc
175bacf
dae9450
03b9411
1358215
ca42c30
28d39f4
92a8327
3264517
1ba1481
f81c34b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the action just to redirect really needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a few cases, where the browser encountered an error on the POST to
/queries/1
and that then showed up as the URL in the browser, when refreshing I was met with a 404 error. Personally, I want to surprise the user the least, and if they refresh they should land on a page that makes sense and that what this redirect doesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you mean resubmitting the url from the url bar, as refresh of post POST by browsers should still be a POST request (discussion about it). Not sure it will reduce user surprise, as changes that were in post data will be gone