Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[Op#23673]: Merge btey/openproject-gitlab-integration 🎉 #14881

Conversation

akabiru
Copy link
Member

@akabiru akabiru commented Feb 28, 2024

https://community.openproject.org/projects/openproject/work_packages/23673

btey/openproject-gitlab-integration#59

Purpose:

The goal of this integration is to make GitLab's units of work (merge requests and issues) manageable from within OpenProject by

  1. Linking GitLab's merge requests with work packages and
  2. Linking GitLab's issues with work packages

Integration Tasks

  • Code review of the existing GitLab plugin
  • Check security aspects
  • Change URL to repo in plugin overview /admin/plugins
    • Bump version to 3.0.0 to prevent clashes
    • Update gemspec authors to include OpenProject and Ben Tey
    • Review /admins/plugins page
  • Come up with a migration path for existing plugin installations (OP#53297)
    • Migrations check that they don't conflict with previous plugin integrations
  • Write tests Implementation/53117 Add automated tests for the critical path of gitlab integration #14899
    • (Only the most vital ones. Keeping in mind that this code is already in production on some people's servers. It should work.)
    • Add setup documentation for admins. (Op#53299)
    • Update module README.md
    • Consolidate with GitHub integration and remove code duplication, wherever it is worth it.
  • Clarify LICENSE update from btey/openproject-gitlab-integration

Out of scope:

  • Full test coverage
  • Adoption of Primer design system
  • Further features

btey and others added 30 commits March 15, 2021 11:20
Remove requiring changes to the OpenProject core
Update version in Readme.
Set this version as stable.
Add the necessary dependency to Gemfile.lock which was missing in the Readme.
Updating Readme referencing official OpenProject Docker documentation
Don't try to output link on new record
…_github_integration_docs

Update README with current link to GitHub integration docs
Some updates and fixes from the community. Thank you all!
@akabiru akabiru force-pushed the implementation/53019-bring-bteyopenproject-gitlab-integration-into-a-structure-that-matches-openproject branch from 1a70966 to e3c4388 Compare March 2, 2024 12:40
Copy link
Member Author

@akabiru akabiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • @lindenthal URL to repo in plugin overview /admin/plugins updated ✅

7c791a4

Screenshot 2024-03-06 at 5 04 27 PM

@akabiru akabiru marked this pull request as ready for review March 6, 2024 14:26
@akabiru akabiru requested a review from ba1ash March 6, 2024 14:26
akabiru and others added 2 commits March 6, 2024 17:49
…tlab-integration-into-a-structure-that-matches-openproject
…-tests-for-the-critical-path

Implementation/53117 Add automated tests for the critical path of gitlab integration
@akabiru akabiru merged commit 29b1cc0 into dev Mar 6, 2024
13 checks passed
@akabiru akabiru deleted the implementation/53019-bring-bteyopenproject-gitlab-integration-into-a-structure-that-matches-openproject branch March 6, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

10 participants