Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change design of loading indicator #13251

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Change design of loading indicator #13251

merged 2 commits into from
Jul 26, 2023

Conversation

HDinger
Copy link
Contributor

@HDinger HDinger commented Jul 26, 2023 •
edited
Loading

@oliverguenther oliverguenther self-requested a review July 26, 2023 11:23
@oliverguenther
Copy link
Member

@HDinger Looking good to me. One spec is correctly failing it seems

  1) Status action board with full boards permissions does not change moving card project when filtering on projects (Bug #44895)
     Failure/Error: example.run
       expected to find css ".loading-indicator" but there were no matches
     # ./modules/boards/spec/features/support/board_page.rb:180:in `wait_for_lists_reload'
     # ./modules/boards/spec/features/action_boards/status_board_spec.rb:141:in `block (3 levels) in <top (required)>'

@oliverguenther oliverguenther merged commit 06f7fca into dev Jul 26, 2023
11 of 12 checks passed
@oliverguenther oliverguenther deleted the feature/48211-new-loading-indicator-for-openproject-application branch July 26, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverguenther oliverguenther oliverguenther approved these changes

Assignees
No one assigned
Labels
feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HDinger @oliverguenther