-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#48649] PDF Export: Filter attributes table #13250
Merged
as-op
merged 6 commits into
dev
from
feature/48649-filter-attributes-table-in-the-pdf-export
Jul 27, 2023
Merged
[#48649] PDF Export: Filter attributes table #13250
as-op
merged 6 commits into
dev
from
feature/48649-filter-attributes-table-in-the-pdf-export
Jul 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ork package type * refactor to avoid duplication in filtering https://community.openproject.org/work_packages/48649
…-pdf-export-enabled-for-the-work-package-type
as-op
changed the title
[#48649] Filter attributes table in the pdf export
[#48649] PDF Export: Filter attributes table
Jul 26, 2023
aaron-contreras
requested changes
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice refactor. Only itch would be the unused parameter for both #attributes_list_by_columns
and #attributes_list_by_wp
.
Co-authored-by: Aaron Contreras <[email protected]>
Co-authored-by: Aaron Contreras <[email protected]>
Co-authored-by: Aaron Contreras <[email protected]>
🙏 Thank you @aaron-contreras! |
as-op
deleted the
feature/48649-filter-attributes-table-in-the-pdf-export
branch
July 27, 2023 07:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
https://community.openproject.org/work_packages/48649