Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#48649] PDF Export: Filter attributes table #13250

Merged
merged 6 commits into from
Jul 27, 2023
Merged

[#48649] PDF Export: Filter attributes table #13250

merged 6 commits into from
Jul 27, 2023

Conversation

as-op
Copy link
Contributor

@as-op as-op commented Jul 26, 2023 •
edited
Loading

This PR

  • refactors work package attribute table generation exports to avoid dup code for single/multi-wp-export
  • removes all attributes with empty values from the table

https://community.openproject.org/work_packages/48649

@as-op as-op changed the title [#48649] Filter attributes table in the pdf export [#48649] PDF Export: Filter attributes table Jul 26, 2023
@aaron-contreras aaron-contreras self-requested a review July 26, 2023 23:46
aaron-contreras
aaron-contreras requested changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@aaron-contreras aaron-contreras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice refactor. Only itch would be the unused parameter for both #attributes_list_by_columns and #attributes_list_by_wp.

@as-op
Copy link
Contributor Author

as-op commented Jul 27, 2023

🙏 Thank you @aaron-contreras!

@as-op as-op merged commit 948c6be into dev Jul 27, 2023
9 of 10 checks passed
@as-op as-op deleted the feature/48649-filter-attributes-table-in-the-pdf-export branch July 27, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron-contreras aaron-contreras aaron-contreras requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@as-op @aaron-contreras