[#49081] PDF-Export: Add tests for pdf content #13238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts, do not hardcode column names
klaustopher
approved these changes
Jul 31, 2023
Comment on lines
+92
to
+97
| content = export_pdf.content | ||
| # File.binwrite('WorkPackageToPdf-test-preview.pdf', content) | ||
| { strings: PDF::Inspector::Text.analyze(content).strings, | ||
| images: PDF::Inspector::XObject.analyze(content).page_xobjects.flat_map do |o| | ||
| o.values.select { |v| v.hash[:Subtype] == :Image } | ||
| end } |
There was a problem hiding this comment.
❓ In the other test we are writing the PDF to disk, here we are checking the content directly. Can't we use the same procedure in the other file as well?
There was a problem hiding this comment.
The (other) query based export does have a feature to batch exporting thousands of work packages (with images) to different pdfs and concats them in the end with an external tool. Granted, the batching is currently not triggered in the spec, but this change wouldn't have much benefits.
Comment on lines
83
to
89
| def column_title(column_name) | ||
| label_title(column_name).upcase | ||
| end | ||
|
|
||
| def label_title(column_name) | ||
| WorkPackage.human_attribute_name(column_name) | ||
| end |
There was a problem hiding this comment.
It's only 2 methods, but they are the same here and in the other test. We could put them in a module in spec/support/ and include that module in both tests
…or-pdf-content' into implementation/49081-add-tests-for-pdf-content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
https://community.openproject.org/work_packages/49081