Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#49285] Fix flaky specs modules/storages/spec/features/{manage_project_storage_spec.rb,create_file_links_spec.rb} #13236

Merged
merged 3 commits into from
Jul 26, 2023
Merged

[#49285] Fix flaky specs modules/storages/spec/features/{manage_project_storage_spec.rb,create_file_links_spec.rb} #13236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46d9248
[#49285] Fix flaky spec ./modules/storages/spec/features/manage_proje…
akabiru Jul 25, 2023
f9d4ae5
[#49285] Fix flaky spec ./modules/storages/spec/features/create_file_…
akabiru Jul 25, 2023
2263410
[#49285] Fix flaky spec ./modules/storages/spec/features/manage_proje…
akabiru Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/storages/spec/features/create_file_links_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
before do
allow(Storages::FileLinkSyncService).to receive(:new).and_return(sync_service)

stub_request(:get, "https://host1.example.com/ocs/v1.php/cloud/user")
stub_request(:get, "#{storage.host}/ocs/v1.php/cloud/user")
.with(
headers: {
'Authorization' => 'Bearer 1234567890-1',
Expand Down
5 changes: 2 additions & 3 deletions modules/storages/spec/features/manage_project_storage_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,6 @@
end

before do
skip("Flaky test disabled. Fix it in https://community.openproject.org/wp/49285")

oauth_client_token

stub_request(:propfind, "#{storage.host}/remote.php/dav/files/#{oauth_client_token.origin_user_id}/")
Expand Down Expand Up @@ -117,7 +115,8 @@
page.find('.toolbar .button--icon.icon-add').click
expect(page).to have_current_path new_project_settings_projects_storage_path(project_id: project)
expect(page).to have_text('Add a file storage')
expect(page).to have_select('storages_project_storage_storage_id', options: ['Storage 1 (nextcloud)'])
expect(page).to have_select('storages_project_storage_storage_id',
options: ["#{storage.name} (#{storage.short_provider_type})"])
page.click_button('Continue')

# by default automatic have to be choosen if storage has automatic management enabled
Expand Down
Loading