-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/file link sync service refactoring #13223
Conversation
- Query now takes an array of file IDs - Query outputs and array of StorageFileInfo objects - Added a converter helper to convert StorageFileInfo into a StorageFile
…opy-filelinks-respecting-the-location-of-the-files
…ervice-refactoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a ton. >.< I've used an traffic light system to make notes on what I think is:
🟢 Just me being weird or minor suggestions
🟡 Points that warrant clarification discussion
🔴 (which I use sparingly) Major issues that need to be addressed before a merge
modules/storages/app/common/storages/peripherals/storage_file_info_converter.rb
Show resolved
Hide resolved
modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/file_id_query.rb
Outdated
Show resolved
Hide resolved
...s/storages/app/common/storages/peripherals/storage_interaction/nextcloud/files_info_query.rb
Outdated
Show resolved
Hide resolved
...s/storages/app/common/storages/peripherals/storage_interaction/nextcloud/files_info_query.rb
Show resolved
Hide resolved
...s/storages/app/common/storages/peripherals/storage_interaction/nextcloud/files_info_query.rb
Outdated
Show resolved
Hide resolved
modules/storages/app/services/storages/file_link_sync_service.rb
Outdated
Show resolved
Hide resolved
modules/storages/app/services/storages/file_link_sync_service.rb
Outdated
Show resolved
Hide resolved
…ervice-refactoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
No description provided.