Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meetings with agenda tops prototype #12953

Closed
wants to merge 73 commits into from
Closed

Conversation

jjabari-op
Copy link
Collaborator

@jjabari-op jjabari-op commented Jun 26, 2023

Evaluating Primer and Hotwire/ViewComponents in combination while prototyping a new feature (agenda items for meetings)

-> Navigate to project meetings and create a new meeting. You will find the option to create agenda_items there.

Findings towards Primer so far:

  • Our list styles break the border_box component (which renders rows as li elements) -> our margin-left conflicts with the Primer style
  • Our form styles break the Primer form styles -> Primer inputs should have a border-radius and different label margins (new or edit state of agenda_items show the broken Primer forms)
  • I've created a primer adjustments css which would fix these issues but then disabled it in order not to hide these effects (frontend/src/global_styles/openproject/_primer-adjustments.sass)

Finding towards Hotwire&ViewComponents:

The long term goal of this spike is to develop a concept for this EPIC: https://community.openproject.org/projects/openproject/work_packages/37297/activity

@jjabari-op jjabari-op self-assigned this Jun 26, 2023
@jjabari-op jjabari-op marked this pull request as draft June 26, 2023 13:33
@jjabari-op jjabari-op changed the base branch from dev to lookbook-primer June 26, 2023 13:35
@lindenthal lindenthal marked this pull request as ready for review August 4, 2023 09:57
@mereghost mereghost deleted the meetings_with_agenda_tops branch September 2, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants