Improve InstallPlan error handling
#3404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
With this change we no set condition on subscriptions about errors during InstallPlan creation. Previously we were only logging these errors. Signed-off-by: Mikalai Radchuk <[email protected]>
m1kola
force-pushed
the
update_subs_on_ensure_IP_error
branch
from
4ac78bc
to
38911d2
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Looks like a flake in a merge queue |
Merged
via the queue into
operator-framework:master
with commit Sep 29, 2024
75d70e6
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
With this change we no set condition on subscriptions about errors during
InstallPlancreation.Previously we were only logging these errors.
Motivation for the change:
We recently seen failures on
InstallPlanstatus update because the size of status exceeded request limit (InstallPlanwas over 2.1M). A failure like this is currently not visible to the end user and it only possible to see from the OLM debug logs.Architectural changes:
Testing remarks:
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue