Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove metadata conversion #190

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

aryanA101a
Copy link

@aryanA101a aryanA101a commented Feb 19, 2024

Fixes #188

@rgaudin rgaudin self-requested a review February 19, 2024 09:09
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aryanA101a, thank you ; but:

  • we still need to encode to bytes.
  • if you remove code, you should remove associated test. This proves you didn't run the tests locally… well you should

FYI we'll only merge this once we want to release a new major version as this is an API break and we're in no rush to do so

@aryanA101a
Copy link
Author

aryanA101a commented Feb 19, 2024

@rgaudin Sorry, my bad.
Actually, I ran the tests after the modification but didn't install the project.

@kelson42
Copy link
Contributor

@aryanA101a Any update?

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;

Must NOT be merged!. This is an API break; we'll merge once we know we're ready to publish a major version

@rgaudin rgaudin marked this pull request as draft April 2, 2024 12:42
@rgaudin
Copy link
Member

rgaudin commented Apr 2, 2024

converted to draft to prevent accidental merge

@benoit74
Copy link

benoit74 commented Apr 4, 2024

I don't think this is sufficient: type hints should be simplified as well to explicitly mention these methods support only bytes and str values now (i.e. conversion must be done by python-scraperlib or any other "user")

@rgaudin
Copy link
Member

rgaudin commented Apr 4, 2024

Thank you @benoit74 ; that's right and I forgot @aryanA101a to mention that you should not force-push after having asked for a review ; it makes (and made in that case) reviewing a real pain.

@rgaudin
Copy link
Member

rgaudin commented Apr 4, 2024

@aryanA101a please update type hints as suggested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove metadata conversion from python-libzim
4 participants