Fixed #172: platform only checked if downloading

openzim · Sep 12, 2023 · faccfbe · faccfbe
1 parent b893d2a
commit faccfbe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 - Build with (and target) libzim 8.2.1
+- Fixed setup checking download platform even when using own libzim (not downloading)
 
 ## Removed
 

diff --git a/setup.py b/setup.py
@@ -149,6 +149,7 @@ def get_download_filename(self, arch: Optional[str] = None) -> str:
 
     def download_to_dest(self):
         """download expected libzim binary into libzim/ and libzim/include/ folders"""
+        self.check_platform()
         if self.wants_universal:
             folders = {}
             for arch in self.supported_platforms["Darwin"]:
@@ -474,7 +475,6 @@ def finalize_options(self):
         ...
 
     def run(self):
-        config.check_platform()
         config.download_to_dest()
 
 
@@ -494,7 +494,6 @@ def run(self):
 if len(sys.argv) == 2 and sys.argv[1] in config.buildless_commands:
     ext_modules = None
 else:
-    config.check_platform()
     ext_modules = get_cython_extension()
 
 setup(