-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openvpn] Remove mandatory items #183
Conversation
Looks good, but deferring to Fed. |
5971be3
to
cd0d762
Compare
@nemesisdesign I rebased this to current master. Please let me know if there's anything which keeps this from getting merged. |
cd0d762
to
0968e43
Compare
@nemesisdesign What about this one? This is in the queue for one and a half year... |
Sorry for having forgotten this. I want to bring up again the subject of #120 to add easy ways to enable changes to the backends, changes could mean enabling optional schema sections for openwrt packages that are not installed by default or register schema changes like this. |
I'm already maintaining a patch for this for one and a half year and we use it since then without problems - that's why I wanted to get this upstream and get rid of the patch ;-) |
@okraits instead of patching the library, you can apply this patch in your django project, import the module in the settings and update the schema dictionary there, you will not need to maintain a fork of netjsonconfig, that's how I have been doing it and it's working pretty well so I recommend it to you too. |
@nemesisdesign Why did you close the PR? Don't you want to fix this issue? |
@okraits as I said, this cannot be accepted as it can create issues on systems which rely on these checks. Instead of patching the library, you can apply this patch in your django project, import the module in the settings and update the schema dictionary there, you will not need to maintain a fork of netjsonconfig, that's how I have been doing it and it's working pretty well so I recommend it to you too. If I am missing something let me know and give me more details please. |
In certain situations, especially when modifying an existing openvpn config, it shouldn't be necessary to provide certain items as they might already exist in the openvpn config.