feat: add PINExplainer pre-screen to the PINCreate screen to explain the use of the PIN #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 22, 2024 00:47
Signed-off-by: Jian Wang <[email protected]>
Signed-off-by: Jian Wang <[email protected]>
|
jleach
changed the title
bryce-mcmath
requested changes
Oct 22, 2024
Comment on lines
+170
to
+174
| <> | ||
| { explained || | ||
| <PINExplainer continueCreatePIN={continueCreatePIN} /> | ||
| } | ||
| { explained && |
There was a problem hiding this comment.
I believe this should be a ternary expression:
return explained ? (<KeyboardView>...</KeyboardView>) : (<PINExplainer continueCreatePIN={continueCreatePIN} />)
That way we won't need the fragment and we won't risk odd UI bugs
| continueCreatePIN: () => void | ||
| } | ||
|
|
||
| const Component: React.FC<PINExplainerProps> = ({ continueCreatePIN }) => { |
There was a problem hiding this comment.
Suggested change
| const Component: React.FC<PINExplainerProps> = ({ continueCreatePIN }) => { | |
| const PINExplainer: React.FC<PINExplainerProps> = ({ continueCreatePIN }) => { |
Component should be named even though it's a default export, it's the existing pattern and it helps readability.
Comment on lines
+47
to
+51
| // const navigation = useNavigation<StackNavigationProp<AuthenticateStackParams>>() | ||
| const pressBack = () => { | ||
| // No handler on Back action yet | ||
| // navigation.navigate(Screens.Terms) | ||
| } |
There was a problem hiding this comment.
Since we're going with the component approach and it's not a separate screen, this can be removed
Comment on lines
+2
to
+6
| /* | ||
| import { useNavigation } from '@react-navigation/native' | ||
| import { StackNavigationProp } from '@react-navigation/stack' | ||
| import { AuthenticateStackParams, Screens } from '../../types/navigators' | ||
| */ |
Comment on lines
+88
to
+96
| <View style={[{ paddingTop: 10, marginBottom: 20 }]}> | ||
| <Button | ||
| title={t('Global.Back')} | ||
| accessibilityLabel={t('Global.Back')} | ||
| testID={testIdWithKey('Back')} | ||
| onPress={pressBack} | ||
| buttonType={ButtonType.Secondary} | ||
| /> | ||
| </View> |
There was a problem hiding this comment.
Can be removed but don't forget to move the marginBottom: 20 to the button above that we are keeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
New screen added before PIN Set-up to explain the use of the PIN in the wallet to the user. The pre-screen is displayed on navigating to Pin Create screen, the user need to click CONTINUE to access the PIN creating form
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.