Add vw e golf #932
Open
Add vw e golf #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jared, welcome & thanks for contributing! Apparently this is currently not more than an empty stub, so I cannot merge this yet. I assume you've got an initial release in the pipeline? Your namespace / vehicle type choices are fine. Consider using "xvg" as the custom metrics/config namespace. Looking forward to your initial release. Regards, |
|
Hello, Thanks for the feedback. Yes, a more substantial release will be coming. I am currently logging CAN bus, and trying to figure out how everything works in the car. I will post to the discord with any questions/issues. -Jared |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.