GPOS lookupType 9 support #491
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ILOVEPIE
requested changes
Feb 2, 2023
| @@ -36,6 +36,8 @@ Position.prototype.getKerningValue = function(kerningLookups, leftIndex, rightIn | |||
| const subtables = kerningLookups[i].subtables; | |||
| for (let j = 0; j < subtables.length; j++) { | |||
| const subtable = subtables[j]; | |||
| // Subtables not supported come with an error | |||
| if (subtable.error) continue; | |||
There was a problem hiding this comment.
Maybe make it log the error when it comes across one?
Draft
8 tasks
|
Pinging @AlexandreRivet |
|
This will be covered by #557 |
Connum
force-pushed
the
feat/gpos-extended-kerning
branch
from
a83fe80
to
995ec63
Compare
I was about to close this but tested it before just in case, and with this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for GPOS lookupType 9 to be able to manage other extended lookupType. 🤩
Motivation and Context
I noticed, by using this font WorkSans, I was not able to get kerning values. Diving into this problem, I found it was because GPOS lookupType 9 was not supported and only lookupType 2 was used in getKerningTables.
How Has This Been Tested?
Types of changes
Checklist:
npm run testand all tests passed green (including code styling checks).