Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean session disconnect event even if an error occurs #625

Open
wants to merge 4 commits into
base: 0.21.4
Choose a base branch
from

Conversation

enricop89
Copy link
Contributor

This PR fixes #271.

Credits: @vineus

@vineus
Copy link

vineus commented Nov 25, 2022

Thanks a lot for the PR! 🙇

Will test it

@vineus
Copy link

vineus commented Nov 28, 2022

@enricop89 it works perfectly Thanks a ton!

@pietgk
Copy link
Contributor

pietgk commented Jan 2, 2023

@enricop89 @abdulajet will this PR be merged?

@enricop89 enricop89 changed the base branch from 0.21.2 to 0.21.4 March 24, 2023 09:37
@marinaserranomontes marinaserranomontes changed the base branch from 0.21.4 to develop October 27, 2023 16:57
@marinaserranomontes marinaserranomontes changed the base branch from develop to 0.21.4 October 27, 2023 16:57
@pietgk
Copy link
Contributor

pietgk commented Nov 29, 2023

Why is this PR not merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants