VIDCS-974: React Native- IOS: App crash (#675)

* VIDCS-974: React Native- IOS: App crash * code review updates * Rev version to 2.25.2 --------- Co-authored-by: Jeronimo Valli <[email protected]> Co-authored-by: Jeff Swartz <[email protected]>
opentok · Jul 5, 2023 · d327d99 · d327d99
1 parent 737d059
commit d327d99
Show file tree

Hide file tree

Showing 5 changed files with 96 additions and 285 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+# 2.25.2 (July 5 2023)
+
+- [Fix]: Fix crash on iOS when publishing a screen-sharing stream.
+
 # 2.25.1  (June 27 2023)
 
 - [Fix]: Fix camera lifecycle on Android. - issue #645

diff --git a/ios/OpenTokReactNative/OTScreenCapture.h b/ios/OpenTokReactNative/OTScreenCapture.h
@@ -10,13 +10,6 @@
 
 @protocol OTVideoCapture;
 
-// defines for image scaling
-// From https://bugs.chromium.org/p/webrtc/issues/detail?id=4643#c7 :
-// Don't send any image larger than 1280px on either edge. Additionally, don't
-// send any image with dimensions %16 != 0
-#define MAX_EDGE_SIZE_LIMIT 1280.0f
-#define EDGE_DIMENSION_COMMON_FACTOR 16.0f
-
 /**
  * Periodically sends video frames to an OpenTok Publisher by rendering the
  * CALayer for a UIView.
@@ -30,9 +23,5 @@
  */
 - (instancetype)initWithView:(UIView*)view;
 
-// private: declared here for testing scaling & padding function
-+ (void)dimensionsForInputSize:(CGSize)input
-                 containerSize:(CGSize*)destContainerSize
-                      drawRect:(CGRect*)destDrawRect;
 
 @end