refactor: change unregisterCreatureEvent from while to std::erase_if

[dudantas]

Description

This pull request refactors the loop used to erase elements from eventsList to use std::erase_if, simplifying the code and improving its readability. The intent of the loop is maintained, while reducing the manual iteration and conditional erasure boilerplate.

Behaviour

Actual

Manual iteration over the eventsList, with explicit element erasure and control flow to maintain correct flag setting.

Expected

std::erase_if is used to achieve the same functionality in a more concise way, directly removing elements matching the given condition while preserving the required state changes.

Type of change

Please delete options that are not relevant.

• Code refactor (non-breaking change that improves the code quality)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (not applicable)
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works (not applicable)

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud