Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unnecessary function for data-canary #2973

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: remove unnecessary function for data-canary #2973

wants to merge 4 commits into from
+80 −85

Conversation

luanluciano93
Copy link
Contributor

@luanluciano93 luanluciano93 commented Oct 13, 2024 •
edited by murilo09
Loading

Description

For those who use data-canary, these functions are unnecessary and their storages are in data-global

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

murilo09
murilo09 requested changes Oct 14, 2024
View reviewed changes
data/libs/functions/player.lua Outdated Show resolved Hide resolved
@murilo09 murilo09 changed the title improve: unnecessary functions for data-canary fix: unnecessary functions for data-canary Oct 14, 2024
@murilo09 murilo09 changed the title fix: unnecessary functions for data-canary fix: remove unnecessary functions for data-canary Oct 14, 2024
@murilo09 murilo09 changed the title fix: remove unnecessary functions for data-canary fix: remove unnecessary function for data-canary Oct 14, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majestyotbr majestyotbr majestyotbr approved these changes

@murilo09 murilo09 murilo09 approved these changes

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luanluciano93 @majestyotbr @murilo09