Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve nil method error in battlemart.lua callback #2961

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

omarcopires
Copy link
Contributor

@omarcopires omarcopires commented Oct 10, 2024

Description

I replaced the method npc:getFormattedCategoryNames(itemsTable) with the function GetFormattedShopCategoryNames(SupplyShopConfigTable), which correctly formats the shop category names.

This fixes the error and allows the NPC to properly display the selection of item categories.

Problem introduced in #2852

Fix

Interface: Scripts Interface
Script ID: E:\Repositorios Git\baiak-yurots\data-canary/npc\battlemart.lua:callback
Error Description: ...sitorios Git\baiak-yurots\data-canary/npc\battlemart.lua:201: attempt to call method 'getFormattedCategoryNames' (a nil value)
stack traceback:
        [C]: in function 'getFormattedCategoryNames'
        ...sitorios Git\baiak-yurots\data-canary/npc\battlemart.lua:201: in function 'callback'
        data/npclib/npc_system/npc_handler.lua:451: in function 'onSay'
        ...sitorios Git\baiak-yurots\data-canary/npc\battlemart.lua:46: in function <...sitorios Git\baiak-yurots\data-canary/npc\battlemart.lua:45>

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link

sonarcloud bot commented Oct 10, 2024

@dudantas dudantas merged commit 3cd4031 into opentibiabr:main Oct 10, 2024
18 checks passed
@omarcopires omarcopires deleted the fix-battlemart branch October 10, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants