Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the readability of Bank class #2934

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ramon-bernardo
Copy link
Contributor

@ramon-bernardo ramon-bernardo commented Oct 3, 2024

Description

Improve the readability of Bank class; the logic has been simplified, improving readability. isGuild method has been changed to getGuild.

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@ramon-bernardo
Copy link
Contributor Author

Alright, we need Guild to implement SharedObject. However, my Visual Studio seems a bit confused with this class, so I'll continue working on it later.

@phacUFPE
Copy link
Contributor

phacUFPE commented Oct 4, 2024

Alright, we need Guild to implement SharedObject. However, my Visual Studio seems a bit confused with this class, so I'll continue working on it later.

If it is not ready for review or not finished, please switch the PR to DRAFT.

@ramon-bernardo ramon-bernardo marked this pull request as draft October 4, 2024 23:11
Copy link

sonarcloud bot commented Oct 14, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants