fix: circular inclusion related to network/protocol/connection #2924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudantas
force-pushed
the
dudantas/fix-cpp-circular-inclusion
branch
from
bc53ea7
to
e1897d4
Compare
dudantas
force-pushed
the
dudantas/fix-cpp-circular-inclusion
branch
from
f47ea6d
to
7ff9ca0
Compare
dudantas
added a commit
that referenced
this pull request
Oct 9, 2024
Bug Fixes and Improvements
• Fixed a minor bug in the unit test.
• Improved the tests build and run scripts.
• Removed all redundant pch.hpp includes from the .cpp files as the
directive ```target_precompile_headers(${PROJECT_NAME}_lib PUBLIC
pch.hpp)``` now handles that automatically.
• Added the precompiled file correctly in the visual studio solution
• Resolved several circular dependencies involving the following
components:
- Connection
- KV
- Protocol
dudantas
added a commit
that referenced
this pull request
Oct 9, 2024
Bug Fixes and Improvements
• Fixed a minor bug in the unit test.
• Improved the tests build and run scripts.
• Removed all redundant pch.hpp includes from the .cpp files as the
directive ```target_precompile_headers(${PROJECT_NAME}_lib PUBLIC
pch.hpp)``` now handles that automatically.
• Added the precompiled file correctly in the visual studio solution
• Resolved several circular dependencies involving the following
components:
- Connection
- KV
- Protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fixes and Improvements
• Fixed a minor bug in the unit test.
• Improved the tests build and run scripts.
• Removed all redundant pch.hpp includes from the .cpp files as the directive
target_precompile_headers(${PROJECT_NAME}_lib PUBLIC pch.hpp)now handles that automatically.• Resolved several circular dependencies involving the following components:
Connection
KV
Protocol