fix: empty check and iterator validation in ContainerIterator::advance() #2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudantas
force-pushed
the
dudantas/fix-crash-on-container-advance
branch
from
0391d76
to
003da9f
Compare
…vance() Description: This PR adds an !over.empty() check in ContainerIterator::advance() to ensure the iterator does not access an empty queue or go out of bounds during container iteration. Key Changes: Added validation to prevent accessing over.front() when the over queue is empty. Ensured the iterator cur is correctly repositioned to the next container, preventing out-of-bounds access to itemlist. This improves the stability and prevents potential crashes during container iteration.
dudantas
force-pushed
the
dudantas/fix-crash-on-container-advance
branch
from
6ccab61
to
61b5701
Compare
dudantas
changed the title
dudantas
changed the title
phacUFPE
approved these changes
Sep 18, 2024
majestyotbr
approved these changes
Sep 23, 2024
|
Closing in favor of: #2901 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds an !over.empty() check in ContainerIterator::advance() to ensure the iterator does not access an empty queue or go out of bounds during container iteration.
Key Changes:
Added validation to prevent accessing over.front() when the over queue is empty.
Ensured the iterator cur is correctly repositioned to the next container, preventing out-of-bounds access to itemlist.
This improves the stability and prevents potential crashes during container iteration.